fix(DnD): fix drag and drop in Shadow DOM #11975
Merged
+1,202
−222
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aborjinik
previously requested changes
Jul 28, 2025
aborjinik
reviewed
Jul 28, 2025
TeodorTaushanov
changed the title
TeodorTaushanov
changed the title
dimovpetar
approved these changes
Aug 5, 2025
dimovpetar
force-pushed
the
drag_drop_shadow_dom
branch
from
f18cca0 to
ce1dc89
Compare
aborjinik
reviewed
Aug 6, 2025
| @@ -404,7 +404,7 @@ class Table extends UI5Element { | |||
| @i18n("@ui5/webcomponents") | |||
| static i18nBundle: I18nBundle; | |||
|
|
|||
| _events = ["keydown", "keyup", "click", "focusin", "focusout", "dragenter", "dragleave", "dragover", "drop"]; | |||
| _events = ["keydown", "keyup", "click", "focusin", "focusout", "dragstart", "dragenter", "dragleave", "dragover", "drop", "dragend"]; | |||
TeodorTaushanov
dismissed
aborjinik’s stale review
We would like to keep the DragRegistry and TabContainer logic as simple as possible. We can create a new util that works for the case, where the dragged element is the one, which is clicked. I'll try prepare a change for this, so we can discuss it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira: BGSOFUIRODOPI-3442
fixes #11185